Allow variables in legacy constructor rule #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 90.00%@@ master #692 diff @@
==========================================
Files 72 72
Lines 2351 2351
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2116 2116
Misses 235 235
Partials 0 0
|
|
Great work, thank you! Changelog entry is in the wrong place though. |
blaisesarr
force-pushed
the
allow-variables-in-LegacyConstructorRule
branch
from
10464b8
to
52e4236
Compare
|
@jpsim YES Good catch! it's updated, is it ok? |
|
Yes, thanks for the fantastic contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #646.