Fixed initializer returns doc for implicitly unwrapped optional inits. #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.53% (diff: 100%)@@ master #804 diff @@
==========================================
Files 81 81
Lines 2771 2773 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2453 2455 +2
Misses 318 318
Partials 0 0
|
| @@ -66,7 +66,7 @@ func matchOutsideBraces(declaration: String) -> NSString? { | |||
| } | |||
|
|
|||
| func declarationIsInitializer(declaration: String) -> Bool { | |||
| return !regex("^((.+)?\\s+)?init\\?*\\(.*\\)") | |||
| return !regex("^((.+)?\\s+)?init\\?*\\!*\\(.*\\)") | |||
There was a problem hiding this comment.
I think \\?*\\!* should be [\\?\\!]{0,1}.
|
Could you please add a bug fix entry to the changelog? Thanks! |
| @@ -97,7 +99,7 @@ This release has seen a phenomenal uptake in community contributions! | |||
| [bootstraponline](https://github.com/bootstraponline) | |||
| [#689](https://github.com/realm/SwiftLint/issues/689) | |||
|
|
|||
| * Add rule to check for private unit tests (private unit tests don't get run | |||
| * Add rule to check for private unit tests (private unit tests don't get run | |||
There was a problem hiding this comment.
This trailing white space is required for the new lines.
There was a problem hiding this comment.
I didn't check other PR's trailing white spaces. I'll double check.
|
Closing this PR since we removed this rule. Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.