Fix ValidIBInspectable rule implementation #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love someone else to verify these. I don't have extensive experience with |
|
I'll defer to @marcelofabri to review this. I'm also not very familiar with |
Current coverage is 86.09% (diff: 100%)@@ master #901 diff @@
==========================================
Files 114 114
Lines 5058 5055 -3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 4355 4352 -3
Misses 703 703
Partials 0 0
|
|
Posting the test result from 8.1 here for reference.
|
|
@dduan Thanks for sharing this. It seems that 1 and 2 are indeed correct. About 3, while Xcode shows the fields in IB, I get errors in runtime: Can you reproduce that? I had to remove all the Also, this needs a rebase because I merged another PR (#886) 😬 |
|
@marcelofabri huh, you are right about the runtime error. So it seems that optionals and IUOs aren't supported at all. |
dduan
force-pushed
the
fix_ibinspectable
branch
from
30c6278
to
3734a9c
Compare
|
@marcelofabri updated with changes only relate to |
dduan
force-pushed
the
fix_ibinspectable
branch
from
3734a9c
to
e238516
Compare
|
@marcelofabri added entry to CHANGLOG. Thanks for reviewing! |
| @@ -45,6 +45,9 @@ | |||
|
|
|||
| ##### Bug Fixes | |||
|
|
|||
| * Rule out a few invalid `@IBInspectable` cases in `valid_ibinspectable`. | |||
There was a problem hiding this comment.
we need two trailing spaces after the . 😬
There was a problem hiding this comment.
Done. This is quite strange. Do you know the reason for it?
There was a problem hiding this comment.
I think it's to force markdown to add a <br/>. From the original spec:
When you do want to insert a
<br />break tag using Markdown, you end a line with two or more spaces, then type return.
1. `NSNumber` is not IB-inspectable at all. 2. Explicitly typed `Optional`s and `ImplicitlyUnwrappedOptional`s aren't supported by `@IBInspectable`, reference type or not.
dduan
force-pushed
the
fix_ibinspectable
branch
from
e238516
to
7d4e0ae
Compare
marcelofabri
approved these changes
Nov 29, 2016
|
Many thanks to both of you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several issue in the current implementation of this rule:
NSNumberis not IB-inspectable at all.Optionals andImplicitlyUnwrappedOptionals aren'tsupported by
@IBInspectable, reference type or not.Supported value types with!s and?s are indeed inspectable, contrary towhat the current implementation deems.
For verification, try these out with this little class:
https://gist.github.com/dduan/da4050ca3a0bce5b4d54d21effb06b24