Updates for Ruby sass -> sassc gem #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! Merge when you have a compelling reason to do so 😄 |
|
Very close now - sassc has made it to 2.1.0.pre3... |
|
Merging with sassc 2.1.0. They've removed the Ruby 2.3 requirement by popular demand which makes life easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR swaps out the
Sassgem forSassCbecause the former is end of life and causes lengthy warnings on installation.SassCis a wrapper of the C implementation and has more features etc. which is good - the .css produced is identical bar a handful of newlines.No great rush to do this: current gem works fine, and we'd ideally wait for a
SassCrelease including sass/sassc-ruby#96 to improve the native build. This also changes the min Ruby from 2.0 to 2.3, which should be fine: 2.3 itself has just gone eol. High Sierra has system Ruby 2.2 though, so anyone still there will need to upgrade something.