Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --pod-sources config option to fix #650 #1172

Merged
merged 2 commits into from
Apr 12, 2020

Conversation

Jon889
Copy link
Contributor

@Jon889 Jon889 commented Apr 11, 2020

This adds the --pod-sources config option to fix #650

It's used in the same way the sources option is used during pod lib lint

So jazzy --podspec Identity.podspec --pod-sources 'https://cdn.cocoapods.org,https://example.com/private-pods.git'

@Jon889
Copy link
Contributor Author

Jon889 commented Apr 11, 2020

btw it seems danger isn't running on the CI, though it still marks it as successful Could not set up API to Code Review site for Danger

@johnfairh
Copy link
Collaborator

Looks good, thanks a lot.

@johnfairh johnfairh merged commit 5193175 into realm:master Apr 12, 2020
@johnfairh
Copy link
Collaborator

re. danger -- turns out we have a Circle setting that prevents it working on PRs from forks. PRs on the main repo look to be intermittently failing there too for a different reason.

@Jon889 Jon889 deleted the jon889-pod-sources branch April 12, 2020 10:30
@Jon889
Copy link
Contributor Author

Jon889 commented Apr 12, 2020

Ah ok, thanks for merging this :)

@robertofrontado
Copy link

robertofrontado commented Apr 17, 2020

Nice work 👍, Do you know when this is going to be released?

@Jon889
Copy link
Contributor Author

Jon889 commented Apr 18, 2020

Thanks! I'm not sure you'll have to ask @johnfairh

@johnfairh
Copy link
Collaborator

Can do a release this week I guess -- @robertofrontado have you had a chance to try out master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using jazzy when podpsec includes dependencies from a private spec repo
3 participants