Realm RecyclerView adapter #14
Conversation
| @@ -23,7 +23,7 @@ configurations { | |||
|
|
|||
| dependencies { | |||
| compile 'com.android.support:appcompat-v7:23.3.0' | |||
|
|
|||
| compile 'com.android.support:recyclerview-v7:23.3.0' | |||
There was a problem hiding this comment.
Can you append a new line after this?
There was a problem hiding this comment.
require instead of compile? I guess we don't have strong dependency on recyclerview version?
There was a problem hiding this comment.
provided isn't supported for AAR's yet. So we either need to find a work-around for this before releasing it or just document how to avoid including it:
compile('io.realm:android-adapters:1.0.1') {
exclude group: 'com.android.support', module: 'recyclerview-v7'
}
In either case I think we should do that outside the scope of this PR
| * Can return null if provided Realm instance by {@link OrderedRealmCollection} is closed. | ||
| * | ||
| * @param index index of the item. | ||
| * @return the item at the specified position, null if adapter data is not valid. |
|
besides some minor comments, 👍 |
| } | ||
|
|
||
| private void addListener(OrderedRealmCollection<T> data) { | ||
| BaseRealm realm = getRealm(data); |
There was a problem hiding this comment.
Since RecyclerView has proper lifecycle methods you can actually use the logic I accidentially added to RealmBaseAdapter here: https://github.com/realm/realm-android-adapters/blob/e395cb11b36f483dfa35f0b9d150f3d3c94e67ff/adapters/src/main/java/io/realm/RealmBaseAdapter.java
Because with a proper remove method you can safely use better listener on RealmResults instead of registering on Realm. That way we avoid updating the RecyclerView on any changes to Realm when using RealmResults.
|
I think the methods for addListener/removeListener can be improved to behave better when working with RealmResults, but apart from that it looks good. |
|
@beeender @cmelchior @dalinaum PR is ready :) |
|
Looks good to me 👍 |
|
👍 |
Fixes #972
Moved to new adapters project.
Old PR: realm/realm-java#2548