Allow non-embedded links in asymmetric objects

realm · Sep 15, 2023 · 9d1a1a6 · 9d1a1a6
1 parent a3717e4
commit 9d1a1a6
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 23 deletions.
diff --git a/src/realm/object-store/object_schema.cpp b/src/realm/object-store/object_schema.cpp
@@ -296,13 +296,6 @@ static void validate_property(Schema const& schema, ObjectSchema const& parent_o
                                 object_name, prop.name, prop.object_type);
         return;
     }
-    if (parent_object_schema.table_type == ObjectSchema::ObjectType::TopLevelAsymmetric &&
-        it->table_type != ObjectSchema::ObjectType::Embedded) {
-        exceptions.emplace_back(
-            "Asymmetric table with property '%1.%2' of type '%3' cannot have a non-embedded object type.",
-            object_name, prop.name, string_for_property_type(prop.type));
-        return;
-    }
     if (it->table_type == ObjectSchema::ObjectType::TopLevelAsymmetric) {
         exceptions.emplace_back("Property '%1.%2' of type '%3' cannot be a link to an asymmetric object.",
                                 object_name, prop.name, string_for_property_type(prop.type));

diff --git a/src/realm/table.cpp b/src/realm/table.cpp
@@ -415,10 +415,6 @@ ColKey Table::add_column(Table& target, StringData name)
     Group* target_group = target.get_parent_group();
     REALM_ASSERT_RELEASE(origin_group && target_group);
     REALM_ASSERT_RELEASE(origin_group == target_group);
-    // Only links to embedded objects are allowed.
-    if (is_asymmetric() && !target.is_embedded()) {
-        throw IllegalOperation("Object property not supported in asymmetric table");
-    }
     // Incoming links from an asymmetric table are not allowed.
     if (target.is_asymmetric()) {
         throw IllegalOperation("Ephemeral objects not supported");

diff --git a/test/object-store/schema.cpp b/test/object-store/schema.cpp
@@ -410,18 +410,6 @@ TEST_CASE("Schema") {
                     "Property 'object.link' of type 'object' cannot be a link to an asymmetric object."));
         }
 
-        SECTION("rejects link properties with asymmetric origin object") {
-            Schema schema = {
-                {"object",
-                 ObjectSchema::ObjectType::TopLevelAsymmetric,
-                 {{"link", PropertyType::Object | PropertyType::Nullable, "link target"}}},
-                {"link target", {{"value", PropertyType::Int}}},
-            };
-            REQUIRE_EXCEPTION(schema.validate(SchemaValidationMode::SyncFLX), SchemaValidationFailed,
-                              ContainsSubstring("Asymmetric table with property 'object.link' of type 'object' "
-                                                "cannot have a non-embedded object type."));
-        }
-
         SECTION("allow embedded objects with asymmetric sync") {
             Schema schema = {
                 {"object",