Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove App::Config::local_app_name and App::Config::local_app_version #6811

Closed
nirinchev opened this issue Jul 20, 2023 · 2 comments · Fixed by #6816
Closed

Remove App::Config::local_app_name and App::Config::local_app_version #6811

nirinchev opened this issue Jul 20, 2023 · 2 comments · Fixed by #6816
Assignees

Comments

@nirinchev
Copy link
Member

nirinchev commented Jul 20, 2023

Those are unused and the server doesn't seem to know about them either. We should remove them in Core and deprecate them in SDKs.

Relevant slack thread: https://mongodb.slack.com/archives/C010R3CMP3N/p1689848146390919

@kraenhansen
Copy link
Member

I vaguely remember seeing these propagate to the cloud UI. I imagine it's useful for developers to debug sync errors, related to schema mismatches between versions of their app.

@nirinchev
Copy link
Member Author

nirinchev commented Jul 31, 2023

Based on the slack conversation it seems the app name is not parsed at all. The app version is parsed and appears in the logs, I don't believe it's visualized anywhere, but we've asked the cloud team to confirm what we're supposed to do with them.

I've noted that in the PR: #6816 (comment)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants