Remove App::Config::local_app_* parameters #6816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are not used by the server side and not needed in local impl.
nicola-cab
approved these changes
Jul 21, 2023
|
Hm, so this may have been used after all - I can see that at least |
|
Ah, in the thread I assumed it was just referencing "local_app_version". I will ask the baas-core team and get back to you |
tkaye407
approved these changes
Aug 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
They are not used by the server side and not needed in local impl.
Fixes #6811
☑️ ToDos
* [ ] 🚦 Tests (or not relevant)