Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hardware optimized encryption functions #3241

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Use hardware optimized encryption functions #3241

merged 1 commit into from
Feb 26, 2019

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Feb 26, 2019

No description provided.

@realm-probot
Copy link

realm-probot bot commented Feb 26, 2019

Hey - looks like you forgot to add a T:* label - could you please add one?

simonask
simonask approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@simonask simonask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯👌

@realm-ci
Copy link
Contributor

Check the performance result here: https://ci.realm.io/job/realm/job/realm-core/job/PR-3241/1/Performance_Report

finnschiermer
finnschiermer approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@finnschiermer finnschiermer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, should also have tests for realm file with multiple pages for IVs.

@realm-ci
Copy link
Contributor

Check the performance result here: https://ci.realm.io/job/realm/job/realm-core/job/PR-3241/2/Performance_Report

@jedelbo jedelbo changed the base branch from release/5.14.0-patch.0 to release/5.14.0-hotfix.0 February 26, 2019 13:59
@jedelbo jedelbo merged commit 60ce995 into release/5.14.0-hotfix.0 Feb 26, 2019
@jedelbo jedelbo deleted the prepare-5.14.0-patch.0 branch February 26, 2019 14:52
@kneth kneth mentioned this pull request May 3, 2019
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simonask simonask simonask approved these changes

@finnschiermer finnschiermer finnschiermer approved these changes

@bmunkholm bmunkholm Awaiting requested review from bmunkholm

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jedelbo @realm-ci @simonask @finnschiermer