Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .macCatalyst platform to REALM_HAVE_SECURE_TRANSPORT macro #4954

Merged
merged 5 commits into from
Oct 15, 2021

Conversation

leemaguire
Copy link
Contributor

@leemaguire leemaguire commented Oct 13, 2021

The Mac Catalyst platform was excluded from the REALM_HAVE_SECURE_TRANSPORT macro in the Swift Package. This PR adds .macCatalyst to the platforms for that macro.

Fixes realm/realm-swift#7474

This subsequent PR adds a preprocessor guard to try help with Xcode 12.2 not having .macCatalyst available as a platform in SPM.

☑️ ToDos

  • 📝 Changelog update

@cla-bot cla-bot bot added the cla: yes label Oct 13, 2021
@leemaguire
Copy link
Contributor Author

@ironage PTAL, all CI jobs look green now. Unless I'm missing something...

Copy link
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ironage ironage requested a review from tgoyne October 14, 2021 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSL/TLS protocol not supported
3 participants