Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Public Group API prepared for soon-to-arrive Group::remove_table() [BREAKS PUBLIC API] #515
The public Group API has been heavily upgraded to fix old issues, and to properly support the soon-to-be-added
The most important change is that
New tables are added with one of the new functions
These changes will require a careful examination and update of all our language bindings, and it is not likely that the compiler is going to help find the places where changes are needed.
A simpleminded approach to updating a language binding would be to find every occurrence of a call to
Here is a detailed account of the publicly visible changes:
Before merging we need to discuss the integration of this in bindings.
I really don't like to change the semantics of existing methods without getting some compiler assistance to detect it. I'm not aware if this has been discussed in advance of all these changes? Never the less, I've always argued for this more clear meaning of get_table and get_or_add_table..
I understand your concern with respect to the lack of compiler assistance. On the other hand, using
If you want my help, I can general a "high fidelity" list of places where Group::get_table() is called, for Cocoa and Java, then you can consider in each case whether the right new function to call is
And remember that it is always safe to substitute