Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to use 'desc' as property name in Query Parser #5724

Merged
merged 1 commit into from Aug 9, 2022
Merged

Allow to use 'desc' as property name in Query Parser #5724

merged 1 commit into from Aug 9, 2022

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Aug 9, 2022

What, How & Why?

Fixes #5723

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed.

@cla-bot cla-bot bot added the cla: yes label Aug 9, 2022
@jedelbo jedelbo requested a review from nicola-cab August 9, 2022 10:00
nicola-cab
nicola-cab approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@nicola-cab nicola-cab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jedelbo jedelbo merged commit 9b7936d into master Aug 9, 2022
@jedelbo jedelbo deleted the je/query-parser branch August 9, 2022 12:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicola-cab nicola-cab nicola-cab approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query parse error for field name desc
2 participants
@jedelbo @nicola-cab