Js/sectioned notification #5926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoyne
approved these changes
Oct 7, 2022
Comment on lines
405
to
406
| m_previous_key_to_index_lookup.clear(); | ||
| m_prev_section_index_to_key.clear(); |
There was a problem hiding this comment.
I think it might make more sense to assert that these are empty rather than clearing them? If they're non-empty then something's gone wrong.
Comment on lines
1603
to
1605
| coordinator->on_change(); | ||
|
|
||
| REQUIRE(callback_count == 0); |
There was a problem hiding this comment.
Adding a advance_and_notify(*r); and expecting one call here makes this test a bit clearer IMO. I was briefly confused into thinking that it was checking the changeset from the initial notification rather than the second notification below.
|
TBH, I'm not well pleased with this fix either. This was my introduction to the sectioned results code and it was difficult to get into. This fix was the minimal thing I found to solve the user's bug report, because I didn't feel like doing a redesign. I suspect there are further bugs lurking if the sectioned results computes sections based off a linked property but I don't know if we officially support that anyways. |
tgoyne
added a commit
that referenced
this pull request
Oct 21, 2022
…callback() If the SectionedResults had been previously evaluated, reset_section_callback() would leave it in an inconsistent state where m_has_performed_initial_evalutation was false but the previous run info was non-empty. #5926 introduced some assertions that now fail when this happens, but I suspect the actual behavior was also broken before that.
tgoyne
added a commit
that referenced
this pull request
Oct 21, 2022
…callback() (#5965) If the SectionedResults had been previously evaluated, reset_section_callback() would leave it in an inconsistent state where m_has_performed_initial_evalutation was false but the previous run info was non-empty. #5926 introduced some assertions that now fail when this happens, but I suspect the actual behavior was also broken before that.
tgoyne
added a commit
that referenced
this pull request
Oct 26, 2022
…nification * origin/master: (22 commits) Fix a race condition in error reporting for async open (#5968) Updated release notes version bump to 12.11.0 Fix a deadlock with simultaneous sync and nonsync commit notifications while tearing down RealmCoordinator (#5948) Track the last line seen and report it when there's an uncaught exception Verify that the same key is used when opening multiple DBs for a file Add stricter checks for valid reads on encrypted files Run core tests with encryption enabled on windows (#5967) Fix assertion failures after calling SectionedResults::reset_section_callback() (#5965) Add sync integration test for in-memory mode (#5955) Added realm core version to app login request (#5961) The client sending too much data is now reported as a ProtocolError::limits_exceeded (#5956) Updated release notes release core v12.10.0 Fix C-API for realm_object_get_parent (#5960) fixed a bug in recovery when copying embedded lists with a single link property prefix in the path (#5957) Js/sectioned notification (#5926) Use named apikey callbacks Fix IN query with TypedLink as left operator Fix a use-after-free in client reset when the original RealmCoordinator is gone (#5949) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5912
A sectioned results stores a cached map of previous state to report what changed in
m_prev_section_index_to_key. This is refreshed when sections are calculated which happens if theResults::has_changed()returns true. The bug here is that if the first modification is on a linked property (changes are reported through links up to 4 layers deep) then the results has not actually changed, even though there is a change notification triggered on them. This means thatcalculate_sectionshas only run once and it doesn't have any initial values form_prev_section_index_to_keyyet. The solution here is to set the previous values to the initial sections if it is known to be the first run.☑️ ToDos