Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In memory realm #6022

Closed
wants to merge 5 commits into from
Closed

In memory realm #6022

wants to merge 5 commits into from

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Nov 11, 2022 •
edited

What, How & Why?

Title says it all.
Fixes #5991

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed.

@cla-bot cla-bot bot added the cla: yes label Nov 11, 2022
@jedelbo jedelbo changed the base branch from master to next-major November 11, 2022 13:17
finnschiermer
finnschiermer suggested changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@finnschiermer finnschiermer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think SlabAlloc::resize_file needs to grab m_mapping_mutex. Perhaps others too?

Base automatically changed from next-major to master November 21, 2022 13:02
@nhachicha
Copy link
Contributor

@jedelbo what is the behaviour of realm_close/realm_release ? since the Realm data resides in memory, I'm seeing some Catch2 tests failing because of an existing primary key, which might indicate the Realm was not released ...

Note, I'm not calling realm_delete_files since this requires a path that we're obviously not using since it's an in-memory Realm

@sync-by-unito sync-by-unito bot mentioned this pull request Dec 15, 2022
Closed
@jedelbo jedelbo closed this Feb 21, 2023
@jedelbo jedelbo deleted the je/in-memory-db branch February 21, 2023 10:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@finnschiermer finnschiermer finnschiermer requested changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support creating realms in "pure" in-memory mode
4 participants
@jedelbo @nhachicha @finnschiermer @RedBeard0531