Do not capture this in on_new_flx_subscription_set callback #6129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
CHANGELOG.md
Outdated
| @@ -15,6 +15,7 @@ | |||
| * Compare actual users (`SyncUser::operator!=`), not pointers (`shared_ptr<SyncUser>::operator!=`). ([#realm/realm-dart#1055](https://github.com/realm/realm-dart/issues/1055), since v10.2.0) | |||
| * Core should not alter the order of the properties for additive schemas. ([#6134](https://github.com/realm/realm-core/issues/6134)) | |||
| * Core should not use the version passed in `Realm` constructor to load the schema at some particular version, but only for setting `m_frozen_version`. | |||
| * Fixed possible segfault in sync client where async callback was not extending lifetime of `this` ([#6053](https://github.com/realm/realm-core/issues/6053), since v11.7.0) | |||
There was a problem hiding this comment.
nit: this is not very user friendly; could rephrase into: "Fixed possible segfault in sync client where async callback was using object after being deallocated"
danieltabacaru
approved these changes
Jan 4, 2023
michael-wb
approved these changes
Jan 4, 2023
src/realm/sync/client.cpp
Outdated
| @@ -1058,20 +1058,20 @@ void SessionWrapper::on_new_flx_subscription_set(int64_t new_version) | |||
| return; | |||
| } | |||
|
|
|||
| m_client.post([new_version, this](Status status) { | |||
| auto self = util::bind_ptr<SessionWrapper>(this); | |||
| m_client.get_service().post([new_version, self = std::move(self)](Status status) { | |||
There was a problem hiding this comment.
Keep this as m_client.post(...), since m_client.get_service() is deprecated.
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
We need to make sure we extend the lifetime of the SessionWrapper into the callback of the on_new_flx_subscription_set callback or else we can end up working with already freed memory.
☑️ ToDos