Use NaN for GeoPoint #6490
Merged
Use NaN for GeoPoint #6490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ironage
reviewed
Apr 11, 2023
ironage
reviewed
Apr 11, 2023
ironage
reviewed
Apr 11, 2023
kiburtse
force-pushed
the
kb/geo-parsing
branch
from
d30f42b
to
bc59fad
Compare
kiburtse
force-pushed
the
kb/geo-parsing
branch
from
bc59fad
to
1200853
Compare
ironage
reviewed
Apr 12, 2023
kiburtse
force-pushed
the
kb/geo-parsing
branch
from
1200853
to
3c35304
Compare
ironage
reviewed
Apr 13, 2023
Co-authored-by: James Stone <james.stone@mongodb.com>
ironage
approved these changes
Apr 13, 2023
kiburtse
force-pushed
the
kb/geo-parsing
branch
from
cbef502
to
34c1259
Compare
ironage
added a commit
that referenced
this pull request
Apr 20, 2023
* geospatial query parser support WIP * some error handling * RQL geoSphere * RQL geoPolygon * query geospatial arguments * C-API geospatial in mixed * add a Geospatial type checking API * format * fix warnings on Windows * Alternative syntax definition * API changes from feedback and testing * remove type_GeoPoint as Geospatial is an umbrella for this * additional tests * fix an unused warning * review feedback * Use NaN for GeoPoint (#6490) * Use NaN for altitude, expose to public * Check for NaN for lat/lon --------- Co-authored-by: James Stone <james.stone@mongodb.com> * formatting * remove GeospatialRef and use Geospatial* remove wrong C-API implementation (#6518) --------- Co-authored-by: Jørgen Edelbo <jorgen.edelbo@mongodb.com> Co-authored-by: Kirill Burtsev <kirill.burtsev@mongodb.com>
ironage
added a commit
that referenced
this pull request
May 8, 2023
* Add s2geometry sources for geo queries support from mongodb repo as is * s2: cleanup/remove unneeded files * s2: add to build * Add basic test for s2geometry link * Object store Geospatial mappings * starting queries * s2: cleanup tests related functions * Fix build due to removed error categories * Replace std exceptions with realm specific * Move geo query tests to separate test file for future expansion * Add init types for polygon and center sphere * Add basic geo_within support for Polygon and CenterSphere * Fix windows build * Style: rename geo constants * Fix MacOS compatibility build issue * More win/mac build fixes * Add s2geometry library for swift package build * Suppress s2 warnings for gcc * fix clang-format complaint * Trim down unnecessary S2 sources (#6456) * integrate Realm logging and assertions * remove some string utilities * remove encoder/decoder * remove some base files * remove hash * fix header search path for s2 swift builds * Fix include of external when built as subproject of sdk * Use modern language features (#6466) * scoped_ptr -> std::unique_ptr * use std type_traits * Replace deprecated is_pod with is_trivial --------- Co-authored-by: Kirill Burtsev <kirill.burtsev@mongodb.com> * Use radians for CenterSphere to be unit-neutral (#6496) * Don't use optional for sphere radius to reduce the size of Geospatial * Use radians for CenterSphere radius, expose constant * Add comments about points in Box and Polygon * Don't construct optional needlessly on Geospatial comparison * Geospatial RQL (#6352) * geospatial query parser support WIP * some error handling * RQL geoSphere * RQL geoPolygon * query geospatial arguments * C-API geospatial in mixed * add a Geospatial type checking API * format * fix warnings on Windows * Alternative syntax definition * API changes from feedback and testing * remove type_GeoPoint as Geospatial is an umbrella for this * additional tests * fix an unused warning * review feedback * Use NaN for GeoPoint (#6490) * Use NaN for altitude, expose to public * Check for NaN for lat/lon --------- Co-authored-by: James Stone <james.stone@mongodb.com> * formatting * remove GeospatialRef and use Geospatial* remove wrong C-API implementation (#6518) --------- Co-authored-by: Jørgen Edelbo <jorgen.edelbo@mongodb.com> Co-authored-by: Kirill Burtsev <kirill.burtsev@mongodb.com> * Add REALM_ENABLE_GEOSPATIAL cmake option to disable feature (#6525) * Allow to disable compilation of whole geospatial support * Turn on the geo feature for swift build by default * Remove non-compiling hash_value function (#6533) * Geospatial Polygons support holes (#6529) * Geospatial uses a variant polygon has holes * support holes in polygons in RQL * touch ups * Add REALM_ENABLE_GEOSPATIAL to config.h * add missing include * Fix test build for geo feature, optimize copying (#6550) * Fix build without geospatial * Don't force to copy primitives on get<> * Allow less curly braces for GeoPolygon on init * format --------- Co-authored-by: Jørgen Edelbo <jorgen.edelbo@mongodb.com> Co-authored-by: Kirill Burtsev <kirill.burtsev@mongodb.com> * changelog and test without geospatial on CI * disable geospatial by default for cocoa builds, review feedback * turn off geospatial in swift builds for now * formatting --------- Co-authored-by: Kirill Burtsev <kirill.burtsev@mongodb.com> Co-authored-by: Jørgen Edelbo <jorgen.edelbo@mongodb.com> Co-authored-by: Nikola Irinchev <irinchev@me.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use simple placeholder value for center sphere radius instead of std::optional to reduce size of Geospatial type, since initialisation is controlled through constructors anyway.