Make sync session multiplexing on-by-default #6557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbreams
commented
May 8, 2023
| fi | ||
|
|
||
| if [ -n "${enable_sync_multiplexing|}" ]; then | ||
| set_cmake_var realm_vars REALM_ENABLE_SYNC_MULTIPLEXING BOOL On | ||
| if [ -n "${enable_llvm_coverage|}" ]; then |
There was a problem hiding this comment.
Not sure why these switched places? I guess a weird artifact of a git merge?
kiburtse
reviewed
May 9, 2023
kiburtse
approved these changes
May 10, 2023
michael-wb
approved these changes
May 10, 2023
evergreen/config.yml
Outdated
Comment on lines
103
to
104
| if [ -n "${disable_sync_multiplexing|}" ]; then | ||
| set_cmake_var realm_vars REALM_DISABLE_SYNC_MULTIPLEXING BOOL On |
There was a problem hiding this comment.
I think you need to update this to match the REALM_SYNC_MULTIPLEXING cmake flag
Comment on lines
736
to
741
| SECTION("allowed") { | ||
| sync_multiplexing_allowed = true; | ||
| } | ||
| SECTION("not allowed") { | ||
| sync_multiplexing_allowed = false; | ||
| } |
There was a problem hiding this comment.
This is cool how we can just do this to minimizing the code dups
There was a problem hiding this comment.
This is actually not great as it results in Catch not reporting which mode failed if the test does fail, as the failure won't happen inside the section. bool sync_multiplexing_allowed = GENERATE(false, true); fixes that and is a bit shorter as a bonus.
There was a problem hiding this comment.
Neat, I didn't know about GENERATE(). That's a good tip.
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This updates the sync client's default configuration so that session multi-plexing is on-by-default. The test suite where session multiplexing was enabled now tests the sync client with multiplexing disabled. The
enable_session_multiplexing()method onSyncManageris nowset_session_multiplexing()which lets you explicitly set it to enabled or disabled regardless of how realm was compiled. I also added some object-store level integration tests that test that the function works.☑️ ToDos