Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing [baas] tag that is causing failing tests #6825

Merged
merged 6 commits into from
Jul 25, 2023

Conversation

michael-wb
Copy link
Contributor

@michael-wb michael-wb commented Jul 25, 2023

What, How & Why?

A new test that was added in PR #6823 was missing the "[baas]" tag and was not being run against the baas server during the Evergreen CI tests. (I didn't see that this test was added when merging and missed adding the tag.)

☑️ ToDos

  • [ ] 📝 Changelog update
  • [ ] 🚦 Tests (or not relevant)
  • [ ] C-API, if public C++ API changed.

@michael-wb michael-wb self-assigned this Jul 25, 2023
@cla-bot cla-bot bot added the cla: yes label Jul 25, 2023
@michael-wb michael-wb changed the title Fix merge issue with config.yml that is causing failing tests Add missing [baas] tag that is causing failing tests Jul 25, 2023
Copy link
Contributor

@kiburtse kiburtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up with CI still?

@michael-wb
Copy link
Contributor Author

What's up with CI still?

For the latest Jenkins build for this PR, it looks like the MacOS host selected wasn't available (or became unavailable) when the test ran:

lv_host5_1 was marked offline: Connection was broken: java.nio.channels.ClosedChannelException

@michael-wb michael-wb merged commit a919767 into master Jul 25, 2023
26 of 27 checks passed
@michael-wb michael-wb deleted the mwb/fix-baas-commit branch July 25, 2023 13:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants