Introduce logging categories #7004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedelbo
force-pushed
the
je/core-logging
branch
2 times, most recently
from
390c801
to
2fde0b2
Compare
jedelbo
force-pushed
the
je/core-logging
branch
from
2fde0b2
to
a10ec31
Compare
jedelbo
force-pushed
the
je/core-logging
branch
from
a10ec31
to
b652bc1
Compare
kiburtse
reviewed
Oct 9, 2023
| static LogCategory /**/ transaction; // Creating, advancing and committing transactions | ||
| static LogCategory /**/ query; // Query operations | ||
| static LogCategory /**/ object; // Mutations of the database | ||
| static LogCategory /**/ notification; // Reporting changes to the database |
There was a problem hiding this comment.
storage.notification and all loggers below are not used anywhere. Is something missing?
There was a problem hiding this comment.
It will come in a subsequent PR
There was a problem hiding this comment.
ok, worth a fixme or todo then
| { | ||
|
|
||
| // FIXME use category |
There was a problem hiding this comment.
so how the capi would change to accommodate this?
There was a problem hiding this comment.
The logger function must be able to receive a string indicating the category
kiburtse
approved these changes
Oct 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
☑️ ToDos