Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCORE-1928 Make dependencies.list a YAML file #7394

Merged
merged 5 commits into from Mar 6, 2024

Conversation

jbreams
Copy link
Contributor

@jbreams jbreams commented Feb 28, 2024

What, How & Why?

This is part of my work on using baasaas in core. It makes dependencies.list a YAML file so it's easier to pull into our CI environment.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@cla-bot cla-bot bot added the cla: yes label Feb 28, 2024
@jbreams jbreams marked this pull request as ready for review February 28, 2024 16:13
Copy link

coveralls-official bot commented Feb 28, 2024

Pull Request Test Coverage Report for Build jonathan.reams_3067

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 180 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.05%) to 90.903%

Files with Coverage Reduction New Missed Lines %
test/test_index_string.cpp 1 94.63%
test/test_query2.cpp 1 99.09%
test/test_util_network_ssl.cpp 1 90.71%
src/realm/array_blobs_big.cpp 2 98.72%
src/realm/object-store/shared_realm.cpp 2 93.05%
src/realm/sync/network/http.hpp 2 82.41%
src/realm/uuid.cpp 2 97.01%
src/realm/util/future.hpp 3 95.98%
src/realm/unicode.cpp 4 85.64%
src/realm/util/file.cpp 5 81.02%
Totals Coverage Status
Change from base Build 2103: -0.05%
Covered Lines: 238281
Relevant Lines: 262128

💛 - Coveralls

@@ -1,7 +1,7 @@
PACKAGE_NAME=realm-core
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest changing the file name to dependencies.yaml to formalize the change in syntax.
This would have the effect of self documenting the expected syntax of the file, as well as intentionally breaking scripts or SDKs that depend on this which otherwise might have their parsers broken in difficult to discover ways. Either way, this change probably warrants a note in the "internals" section of the changelog.

@jbreams jbreams requested a review from ironage February 28, 2024 19:09
Copy link
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍

@jbreams jbreams changed the title Make dependencies.list a YAML file RCORE-1928 Make dependencies.list a YAML file Mar 1, 2024
@jbreams jbreams merged commit b4b01be into master Mar 6, 2024
32 of 37 checks passed
@jbreams jbreams deleted the jbr/dependencies_as_yaml branch March 6, 2024 19:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants