Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to get logging level via C API #7419

Merged
merged 2 commits into from Mar 6, 2024
Merged

Add ability to get logging level via C API #7419

merged 2 commits into from Mar 6, 2024

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Mar 6, 2024 •
edited

What, How & Why?

Due to public demand

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@cla-bot cla-bot bot added the cla: yes label Mar 6, 2024
@jedelbo jedelbo requested a review from nicola-cab March 6, 2024 09:50
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Mar 6, 2024 •
edited

Pull Request Test Coverage Report for Build jorgen.edelbo_133

Details

  • 38 of 39 (97.44%) changed or added relevant lines in 3 files are covered.
  • 286 unchanged lines in 24 files lost coverage.
  • Overall coverage decreased (-0.09%) to 90.894%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/realm/object-store/c_api/logging.cpp 19 20 95.0%
Files with Coverage Reduction New Missed Lines %
src/realm/index_string.hpp 1 93.68%
src/realm/sync/instruction_replication.cpp 1 90.49%
src/realm/cluster.cpp 2 77.52%
src/realm/list.cpp 2 88.62%
src/realm/uuid.cpp 2 97.01%
test/test_sync.cpp 2 91.31%
src/realm/sync/client.cpp 3 91.07%
src/realm/sync/network/network.cpp 3 89.73%
src/realm/sync/noinst/server/server.cpp 3 76.31%
src/realm/util/future.hpp 3 95.98%
Totals Coverage Status
Change from base Build 2099: -0.09%
Covered Lines: 238243
Relevant Lines: 262112
💛 - Coveralls

@clementetb
Copy link
Contributor

Looks good to me!

@jedelbo jedelbo merged commit f7d22f2 into master Mar 6, 2024
34 of 37 checks passed
@jedelbo jedelbo deleted the je/logging-c-api branch March 6, 2024 15:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicola-cab nicola-cab nicola-cab approved these changes

Assignees

@jedelbo jedelbo

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jedelbo @clementetb @nicola-cab