New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert back catch2 submodule and up to latest #7509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a changelog entry in the internals stating "Catch2 updated from version X to version Y"?
LGTM once CI passes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI is happy with it - also add the no-jira-ticket
label
Pull Request Test Coverage Report for Build kirill.burtsev_155Details
💛 - Coveralls |
omg these failures... are these known?
log
Log
assertions
|
What, How & Why?
☑️ ToDos
bindgen/spec.yml
, if public C++ API changed