Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCORE-2100: Restore ability to create test users #7632

Merged
merged 2 commits into from Apr 26, 2024
Merged

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Apr 26, 2024

What, How & Why?

This is a follow-up on #7300, where we restore the ability for SDKs to construct a fake user for testing when actual sync session is not necessary. This is only intended to be used for tests and should never be exposed to users.

Fixes #7633.

☑️ ToDos

  • 📝 Changelog update

@nirinchev nirinchev requested a review from tgoyne April 26, 2024 11:21
@cla-bot cla-bot bot added the cla: yes label Apr 26, 2024
@nirinchev nirinchev added no-jira-ticket Skip checking the PR title for Jira reference and removed cla: yes labels Apr 26, 2024
@nirinchev
Copy link
Member Author

The failing test doesn't seem to be related to this change.

@cla-bot cla-bot bot added the cla: yes label Apr 26, 2024
Copy link

Pull Request Test Coverage Report for Build nikola.irinchev_476

Details

  • 0 of 11 (0.0%) changed or added relevant lines in 1 file are covered.
  • 942 unchanged lines in 59 files lost coverage.
  • Overall coverage decreased (-0.002%) to 90.749%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/realm/object-store/sync/app.cpp 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
src/realm/sync/instructions.hpp 1 75.86%
src/realm/sync/network/default_socket.hpp 1 94.12%
src/realm/sync/noinst/server/crypto_server_apple.mm 1 66.28%
src/realm/sync/transform.cpp 1 61.05%
test/test_sync.cpp 1 93.11%
test/test_util_to_string.cpp 1 96.67%
src/realm/array_blob.hpp 2 85.71%
src/realm/object-store/impl/apple/external_commit_helper.cpp 2 74.77%
src/realm/object-store/sync/impl/apple/network_reachability_observer.cpp 2 65.57%
src/realm/owned_data.hpp 2 65.79%
Totals Coverage Status
Change from base Build 2262: -0.002%
Covered Lines: 211964
Relevant Lines: 233573

💛 - Coveralls

@nirinchev nirinchev changed the title Restore ability to create test users RCORE-2100: Restore ability to create test users Apr 26, 2024
@nirinchev nirinchev removed the no-jira-ticket Skip checking the PR title for Jira reference label Apr 26, 2024
@nirinchev nirinchev merged commit 9894889 into master Apr 26, 2024
40 of 44 checks passed
@nirinchev nirinchev deleted the ni/fake-user branch April 26, 2024 16:05
michael-wb added a commit that referenced this pull request Apr 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore ability to create fake users for tests
2 participants