[bindgen] Adding a app_user_as_sync_user helper

[kraenhansen]

What, How & Why?

This introduce a app_user_as_sync_user helper, which can be used by the SDK to downcast an app::User to a SyncUser.

☑️ ToDos

• 📝 Changelog update
• 🚦 Tests (or not relevant)
• C-API, if public C++ API changed
• bindgen/spec.yml, if public C++ API changed

[kraenhansen]

I moved this to the SyncUser as this is where it's actually implemented:

realm-core/src/realm/object-store/sync/sync_user.hpp

Lines 47 to 50 in a45922f

	bool is_logged_in() const
	{
	return state() == State::LoggedIn;
	}

[kraenhansen]

I removed the declaration of this inheritance, because the SDK emits class User extends SyncUser and I saw assertion failures from the User being passed as a SyncUser into the binding, which just interpreted the shared pointer without performing the downcast.

The line giving resulting in assertion failures (the bindingSyncConfig.user is a JS wrapper of app::User but it expects a wrapper of a SyncUser): https://github.com/realm/realm-js/blob/bf7c0c87c460e4adb3cada31df73b74bfa7f1cfc/packages/realm/src/Realm.ts#L384

This happenes because internal.user is User which extends SyncUser and is therefore a valid value for the user here: https://github.com/realm/realm-js/blob/bf7c0c87c460e4adb3cada31df73b74bfa7f1cfc/packages/realm/src/app-services/SyncConfiguration.ts#L341

[coveralls-official]

Pull Request Test Coverage Report for Build kraen.hansen_71

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 93 unchanged lines in 15 files lost coverage.
• Overall coverage decreased (-0.02%) to 90.756%

---

Files with Coverage Reduction	New Missed Lines	%
src/realm/array_mixed.cpp	1	91.91%
src/realm/sync/noinst/server/server_history.cpp	1	63.7%
src/realm/util/file.cpp	1	78.73%
src/realm/util/serializer.cpp	1	90.43%
test/test_query2.cpp	1	98.73%
src/realm/cluster.cpp	2	75.6%
src/realm/object-store/shared_realm.cpp	2	91.89%
src/realm/table_view.cpp	2	92.99%
test/test_util_network.cpp	3	95.44%
src/realm/sync/network/network.cpp	4	87.41%

Totals
Change from base Build 2300:	-0.02%
Covered Lines:	213162
Relevant Lines:	234874

---

💛 - Coveralls

[kraenhansen]

Merging before CI is green, as the previous commit was green and this last change was to the changelog 🤞