Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better init failed message #1006

Merged
merged 3 commits into from
Nov 4, 2022
Merged

better init failed message #1006

merged 3 commits into from
Nov 4, 2022

Conversation

blagoev
Copy link
Contributor

@blagoev blagoev commented Nov 3, 2022

No description provided.

@cla-bot cla-bot bot added the cla: yes label Nov 3, 2022
nielsenko
nielsenko approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3387879493

  • -4 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 88.916%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/native/realm_core.dart 0 2 0.0%
lib/src/realm_object.dart 0 2 0.0%
Totals Coverage Status
Change from base Build 3385625020: -0.8%
Covered Lines: 2214
Relevant Lines: 2490
💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 3, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3387994829

  • 0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 89.609%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/native/realm_core.dart 0 2 0.0%
lib/src/realm_object.dart 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
lib/src/subscription.dart 1 90.48%
Totals Coverage Status
Change from base Build 3385625020: -0.06%
Covered Lines: 2656
Relevant Lines: 2964
💛 - Coveralls

@blagoev blagoev merged commit bf61d01 into master Nov 4, 2022
@blagoev blagoev deleted the blagoev/better-message branch November 4, 2022 06:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nielsenko nielsenko nielsenko approved these changes

@desistefanova desistefanova desistefanova approved these changes

Assignees

@blagoev blagoev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@blagoev @coveralls @nielsenko @desistefanova