implement NativeFinalizers in Realm #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… issue which causes the Dart GC to run too often cause of a bug while collecting memory.
blagoev
commented
Nov 24, 2022
| @@ -85,6 +85,11 @@ class _RealmCore { | |||
| static const libraryVersion = '0.7.0+rc'; | |||
| late String nativeLibraryVersion = _realmLib.realm_dart_library_version().cast<Utf8>().toDartString(); | |||
|
|
|||
| // for debugging only. Enable in realm_dart.cpp | |||
There was a problem hiding this comment.
Should we leave this commented out here for the future?
Pull Request Test Coverage Report for Build 3541339093
💛 - Coveralls |
nirinchev
reviewed
Nov 24, 2022
…/realm-dart into fix-perf-native-finalizers # Conflicts: # src/realm_dart.cpp
nielsenko
approved these changes
Nov 24, 2022
desistefanova
approved these changes
Nov 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement
NativeFinalizersin Realm cause the Dart VMNativeFinalizershave an issue which causes the Dart GC to run too often cause of a bug while collecting memory.Dart VM issue here dart-lang/sdk#50537