Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rip-out vcpkg (use openssl + zlib prebuilds instead) #1069

Merged
merged 5 commits into from
Dec 19, 2022
Merged

Rip-out vcpkg (use openssl + zlib prebuilds instead) #1069

merged 5 commits into from
Dec 19, 2022

Conversation

nielsenko
Copy link
Contributor

@nielsenko nielsenko commented Dec 17, 2022 •
edited
Loading

Resolves: #1059

@cla-bot cla-bot bot added the cla: yes label Dec 17, 2022
@coveralls
Copy link

coveralls commented Dec 17, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3734282288

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 89.248%
Totals Coverage Status
Change from base Build 3731171851: 0.03%
Covered Lines: 2814
Relevant Lines: 3153
💛 - Coveralls

@nielsenko nielsenko force-pushed the kn/drop-vcpkg branch 3 times, most recently from 7c62ce3 to fae6448 Compare December 19, 2022 13:02
@nielsenko nielsenko marked this pull request as ready for review December 19, 2022 18:29
@nielsenko nielsenko merged commit 6f93884 into main Dec 19, 2022
@nielsenko nielsenko deleted the kn/drop-vcpkg branch December 19, 2022 19:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fealebenpae fealebenpae fealebenpae approved these changes

@desistefanova desistefanova desistefanova approved these changes

Assignees

@nielsenko nielsenko

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove using vcpkg from CI and all the build scripts.
4 participants
@nielsenko @coveralls @fealebenpae @desistefanova