Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CollectionChanges cleared notification #1128

Merged
merged 16 commits into from
Jan 30, 2023
Merged

CollectionChanges cleared notification #1128

merged 16 commits into from
Jan 30, 2023

Conversation

desistefanova
Copy link
Contributor

Fixes #795

@cla-bot cla-bot bot added the cla: yes label Jan 30, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4042225899

  • 8 of 9 (88.89%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 88.938%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/collections.dart 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
lib/src/subscription.dart 1 90.48%
Totals Coverage Status
Change from base Build 4025040746: 0.2%
Covered Lines: 2999
Relevant Lines: 3372
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jan 30, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4047413510

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 89.118%
Files with Coverage Reduction New Missed Lines %
lib/src/realm_class.dart 1 93.77%
Totals Coverage Status
Change from base Build 4047372466: 0.05%
Covered Lines: 3030
Relevant Lines: 3400
💛 - Coveralls

@desistefanova desistefanova changed the base branch from main to kn/update-core January 30, 2023 09:28
Base automatically changed from kn/update-core to main January 30, 2023 09:36
@desistefanova desistefanova marked this pull request as ready for review January 30, 2023 09:43
nielsenko
nielsenko reviewed Jan 30, 2023
View reviewed changes
test/realm_set_test.dart Outdated Show resolved Hide resolved
nielsenko
nielsenko approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

blagoev
blagoev suggested changes Jan 30, 2023
View reviewed changes
lib/src/collections.dart Outdated Show resolved Hide resolved
lib/src/collections.dart Outdated Show resolved Hide resolved
test/list_test.dart Outdated Show resolved Hide resolved
test/realm_set_test.dart Outdated Show resolved Hide resolved
@blagoev blagoev merged commit 43f3354 into main Jan 30, 2023
@blagoev blagoev deleted the changes_cleared branch January 30, 2023 20:36
desistefanova added a commit that referenced this pull request Feb 1, 2023
@desistefanova @nielsenko @blagoev
CollectionChanges cleared notification (#1128)
4589697 
* Update realm-core to v13.3.0

* Ran ffigen to update realm_bindings.dart

* Remove realmSetAssign

Not used, and realm_set_assign no longer exposed in C-api.
Apparently it was never implemented.

* Handle new RLM_SYNC_SESSION_STATE_PAUSED

* Update CHANGELOG

* Collection cleared notification

* Test RealmList cleared

* RealmSet.cleared notification

* Modify embedded objects list notification test

* Update Changelog

* Code review changes

* rename cleared to isCleared

* fix test names

* fix bad code

---------

Co-authored-by: Kasper Overgård Nielsen <kasper@byolimit.com>
Co-authored-by: blagoev <lubo@blagoev.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nielsenko nielsenko nielsenko approved these changes

@blagoev blagoev blagoev approved these changes

@nirinchev nirinchev Awaiting requested review from nirinchev

Assignees

@desistefanova desistefanova

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CollectionChanges.isCleared
4 participants
@desistefanova @coveralls @blagoev @nielsenko