Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to load dynamic library #1143

Merged
merged 24 commits into from
Feb 7, 2023
Merged

Failed to load dynamic library #1143

merged 24 commits into from
Feb 7, 2023

Conversation

desistefanova
Copy link
Contributor

@desistefanova desistefanova commented Feb 6, 2023

@cla-bot cla-bot bot added the cla: yes label Feb 6, 2023
@coveralls
Copy link

coveralls commented Feb 6, 2023

Pull Request Test Coverage Report for Build 4114435562

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 89.055%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/init.dart 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
lib/src/subscription.dart 1 90.48%
Totals Coverage Status
Change from base Build 4114274226: -0.05%
Covered Lines: 3035
Relevant Lines: 3408

💛 - Coveralls

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
lib/src/init.dart Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@blagoev
Copy link
Contributor

blagoev commented Feb 6, 2023

@desistefanova This PR seems making too much assumptions about the issue we are trying to fix. Lets keep the changes to a minimum. Only the ones we are sure we need to fix issues

lib/src/init.dart Outdated Show resolved Hide resolved
@desistefanova
Copy link
Contributor Author

@desistefanova This PR seems making too much assumptions about the issue we are trying to fix. Lets keep the changes to a minimum. Only the ones we are sure we need to fix issues

Yes, it was for testing purpose. Since the issue was not reproduced in #1144 for the rest of the environments, I returned back macOS and windows to their latest runners.

.github/workflows/build-native.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
lib/src/init.dart Outdated Show resolved Hide resolved
@desistefanova desistefanova changed the base branch from main to fix_querable_fields February 7, 2023 08:17
@desistefanova desistefanova changed the base branch from fix_querable_fields to blagoev/fix-exception-expectation February 7, 2023 10:17
@desistefanova desistefanova marked this pull request as draft February 7, 2023 10:35
@desistefanova desistefanova marked this pull request as ready for review February 7, 2023 10:50
.github/workflows/flutter-desktop-tests.yml Outdated Show resolved Hide resolved
blagoev and others added 2 commits February 7, 2023 13:27
Co-authored-by: Kasper Overgård Nielsen <kasper.nielsen@mongodb.com>
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly names related

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits left

Base automatically changed from blagoev/fix-exception-expectation to main February 7, 2023 13:14
desistefanova and others added 2 commits February 7, 2023 15:31
Co-authored-by: blagoev <lubo@blagoev.com>
Co-authored-by: blagoev <lubo@blagoev.com>
@desistefanova desistefanova merged commit cb8149d into main Feb 7, 2023
@desistefanova desistefanova deleted the build_runners_ver branch February 7, 2023 13:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants