Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RealmResults.elementAt is slow #1262

Merged
merged 1 commit into from May 3, 2023
Merged

RealmResults.elementAt is slow #1262

merged 1 commit into from May 3, 2023

Conversation

nielsenko
Copy link
Contributor

Iterable.elementAt must be overriden to get good performance.

Fixes: #1261

@nielsenko nielsenko requested a review from blagoev May 3, 2023 12:07
@cla-bot cla-bot bot added the cla: yes label May 3, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4871676474

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 88.782%
Totals Coverage Status
Change from base Build 4865829409: 0.03%
Covered Lines: 3047
Relevant Lines: 3432
💛 - Coveralls

@nielsenko nielsenko merged commit d37f1de into main May 3, 2023
28 of 33 checks passed
@nielsenko nielsenko deleted the kn/results-element-at-performance branch May 3, 2023 12:25
@nielsenko nielsenko mentioned this pull request May 4, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nirinchev nirinchev nirinchev approved these changes

@desistefanova desistefanova desistefanova approved these changes

@blagoev blagoev Awaiting requested review from blagoev

Assignees

@nielsenko nielsenko

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance comparison and issues
4 participants
@nielsenko @coveralls @nirinchev @desistefanova