Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override first, last and single on RealmResults #1267

Merged
merged 4 commits into from
Jun 22, 2023

Conversation

nielsenko
Copy link
Contributor

@nielsenko nielsenko commented May 8, 2023

Avoid instantiating a _RealmResultsIterator for first and
single calls, and avoid iterating the entire collection for last.

@coveralls
Copy link

coveralls commented May 8, 2023

Pull Request Test Coverage Report for Build 5345350646

  • 14 of 15 (93.33%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 88.633%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/results.dart 14 15 93.33%
Files with Coverage Reduction New Missed Lines %
lib/src/subscription.dart 1 90.48%
Totals Coverage Status
Change from base Build 5344969691: -0.008%
Covered Lines: 3236
Relevant Lines: 3651

💛 - Coveralls

@nielsenko nielsenko marked this pull request as ready for review May 8, 2023 10:25
@nielsenko nielsenko requested review from blagoev and desistefanova and removed request for blagoev May 15, 2023 07:52
lib/src/results.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some suggestions on the exceptions mostly. I think we should be doing these optimizations.

lib/src/results.dart Outdated Show resolved Hide resolved
lib/src/results.dart Outdated Show resolved Hide resolved
test/results_test.dart Outdated Show resolved Hide resolved
test/results_test.dart Outdated Show resolved Hide resolved
@nielsenko nielsenko force-pushed the kn/more-overrides-on-results branch from e273c2f to 77f4b75 Compare May 25, 2023 10:53
@nielsenko nielsenko force-pushed the kn/more-overrides-on-results branch 2 times, most recently from 3ae85e3 to 533d690 Compare June 12, 2023 11:00
test/results_test.dart Outdated Show resolved Hide resolved
test/results_test.dart Outdated Show resolved Hide resolved
test/results_test.dart Outdated Show resolved Hide resolved
test/results_test.dart Outdated Show resolved Hide resolved
@nielsenko nielsenko force-pushed the kn/more-overrides-on-results branch 4 times, most recently from 442c7d1 to 4be27da Compare June 21, 2023 12:01
@nielsenko nielsenko force-pushed the kn/more-overrides-on-results branch from 4be27da to 807fb98 Compare June 22, 2023 12:11
@nielsenko nielsenko merged commit e389ffd into main Jun 22, 2023
48 of 49 checks passed
@nielsenko nielsenko deleted the kn/more-overrides-on-results branch June 22, 2023 12:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants