Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RealmSet.freeze #1342

Merged
merged 1 commit into from Jul 31, 2023
Merged

Support RealmSet.freeze #1342

merged 1 commit into from Jul 31, 2023

Conversation

nielsenko
Copy link
Contributor

@nielsenko nielsenko commented Jul 3, 2023 •
edited

Fixes #1341

@cla-bot cla-bot bot added the cla: yes label Jul 3, 2023
@nielsenko nielsenko mentioned this pull request Jul 3, 2023
Closed
@nielsenko nielsenko requested a review from blagoev July 3, 2023 07:19
@coveralls
Copy link

coveralls commented Jul 3, 2023 •
edited

Pull Request Test Coverage Report for Build 5712128194

  • 20 of 20 (100.0%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 88.739%
Files with Coverage Reduction New Missed Lines %
lib/src/list.dart 2 85.93%
Totals Coverage Status
Change from base Build 5633036968: -0.006%
Covered Lines: 3231
Relevant Lines: 3641
💛 - Coveralls

desistefanova
desistefanova approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@desistefanova desistefanova left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have only two small suggestions.

@nielsenko nielsenko merged commit 442d994 into main Jul 31, 2023
49 checks passed
@nielsenko nielsenko deleted the kn/realm-set-freeze branch July 31, 2023 09:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blagoev blagoev blagoev approved these changes

@desistefanova desistefanova desistefanova approved these changes

Assignees

@nielsenko nielsenko

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support RealmSet.freeze
4 participants
@nielsenko @coveralls @blagoev @desistefanova