Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query lists arguments #1346

Merged
merged 16 commits into from
Aug 3, 2023
Merged

Query lists arguments #1346

merged 16 commits into from
Aug 3, 2023

Conversation

desistefanova
Copy link
Contributor

@desistefanova desistefanova commented Jul 3, 2023

This PR adds support for iterable arguments for query with IN-operators for RealmResults, RealmList and RealmSet

  final listOfNames = ['Ani', 'Teddy'];
  var result = realm.query<Person>(r'name IN $0', [listOfNames]);

  final setOfNames = {'Poly', 'Teddy'};
  result = realm.query<Person>(r'name IN $0', [setOfNames]);

  final iterableNames = result.map((e) => e.name);
  result = realm.query<Person>(r'name IN $0', [iterableNames]);

Added support for query on RealmSet.
Allow list of nullable objects when querying on RealmList and RealmSet. It was supported only for RealmResults before.
Fixes #755
Fixes #1084
Inspired by realm/realm-kotlin#1389 and realm-js tests

@coveralls
Copy link

coveralls commented Jul 3, 2023

Pull Request Test Coverage Report for Build 5750372538

  • 56 of 56 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall First build on ds/query_lists_arguments at 88.862%

Totals Coverage Status
Change from base Build 5716391032: 88.9%
Covered Lines: 3255
Relevant Lines: 3663

💛 - Coveralls

@desistefanova desistefanova marked this pull request as ready for review July 11, 2023 12:41
@desistefanova desistefanova marked this pull request as draft July 13, 2023 11:05
@desistefanova desistefanova marked this pull request as ready for review July 14, 2023 13:47
Co-authored-by: blagoev <lubo@blagoev.com>
@desistefanova desistefanova merged commit 553740f into main Aug 3, 2023
49 checks passed
@desistefanova desistefanova deleted the ds/query_lists_arguments branch August 3, 2023 15:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Query method with IN predicate returns empty results Support list comparison in RQL
4 participants