Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kn/results contains and indexOf #1394

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Conversation

nielsenko
Copy link
Contributor

@nielsenko nielsenko commented Sep 1, 2023

Add a RealmResults.indexOf using realm_result_find and implement Iterable.contains on top.

Fixes: #1393
Fixes: #42

@cla-bot cla-bot bot added the cla: yes label Sep 1, 2023
@nielsenko nielsenko force-pushed the kn/results-contains-and-indexOf branch from abb3ea2 to 7ad2851 Compare September 1, 2023 12:35
@nielsenko nielsenko marked this pull request as ready for review September 1, 2023 12:36
@nielsenko nielsenko force-pushed the kn/results-contains-and-indexOf branch from 7ad2851 to 491855e Compare September 1, 2023 12:44
@nielsenko nielsenko force-pushed the kn/results-contains-and-indexOf branch from 491855e to a2d38a1 Compare September 1, 2023 15:13
@nielsenko nielsenko merged commit 9a16bc4 into main Sep 1, 2023
49 checks passed
@nielsenko nielsenko deleted the kn/results-contains-and-indexOf branch September 1, 2023 16:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RealmResults.contains is inefficient Support Results indexOf
2 participants