Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade min flutter to 3.10.0 and min dart to 3.0.0 #1457

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Downgrade min flutter to 3.10.0 and min dart to 3.0.0 #1457

merged 2 commits into from
Jan 23, 2024

Conversation

nielsenko
Copy link
Contributor

No description provided.

@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Jan 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7623060909

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.323%
Totals Coverage Status
Change from base Build 7618617444: 0.0%
Covered Lines: 3706
Relevant Lines: 4244
💛 - Coveralls

nirinchev
nirinchev reviewed Jan 2, 2024
View reviewed changes
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it makes sense to try running the ci.yml to install the minimum supported flutter/dart versions, otherwise we're running this with latest flutter/dart.

@nielsenko
Copy link
Contributor Author

Perhaps it makes sense to try running the ci.yml to install the minimum supported flutter/dart versions, otherwise we're running this with latest flutter/dart.

I agree (and that is my plan), but perhaps we should land #1441 first to reduce the chance of conflicts?

@nirinchev
Copy link
Member

Yeah, I was going to do it, but there is a regression in baasaas that we need to resolve first 😑

@nielsenko
Copy link
Contributor Author

CI will still run latest stable for this PR. To see a CI run where we use Flutter 3.10 / Dart 3.0 see #1474 (which will not be merged).

@nielsenko nielsenko force-pushed the kn/downgrade-min-flutter branch 4 times, most recently from 36ea2c5 to ee61bde Compare January 22, 2024 14:20
@nielsenko nielsenko marked this pull request as ready for review January 23, 2024 09:28
@nielsenko nielsenko merged commit b8b3961 into main Jan 23, 2024
50 checks passed
@nielsenko nielsenko deleted the kn/downgrade-min-flutter branch January 23, 2024 09:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nirinchev nirinchev nirinchev left review comments

Assignees

@nielsenko nielsenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nielsenko @nirinchev