Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flutter app build on Linux #1488

Merged
merged 1 commit into from Jan 24, 2024
Merged

Conversation

thiagokisaki
Copy link
Contributor

This pull request fixes Flutter app build on Linux. Fix #1381.

The execute_process calls in CMakeLists.txt were broken. Neither dart run realm install nor dart run realm metrics were succeeding. Instead, they were returning Could not find file 'realm'.

Realm binaries were not being installed, thus provoking the error during the build.

This was solved by providing WORKING_DIRECTORY option to execute_process.

Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx 👍

@nirinchev
Copy link
Member

@cla-bot check

Copy link

cla-bot bot commented Jan 24, 2024

Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @thiagokisaki. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a @cla-bot check comment. The GitHub usernames you file there will need to match that of your Pull Requests. If you have any questions or cannot file the CLA electronically, make a comment here and we will be happy to help you out.

Copy link

cla-bot bot commented Jan 24, 2024

The cla-bot has been summoned, and re-checked this pull request!

@thiagokisaki
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Jan 24, 2024
Copy link

cla-bot bot commented Jan 24, 2024

The cla-bot has been summoned, and re-checked this pull request!

@nirinchev
Copy link
Member

Thanks for your contribution, @thiagokisaki 🎉

@nirinchev nirinchev merged commit 9d4b542 into realm:main Jan 24, 2024
28 of 47 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants