Use a guaranteed stable sort #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsenko
force-pushed
the
kn/fix-argument-order-not-stable
branch
2 times, most recently
from
fea252b
to
24feeed
Compare
blagoev
approved these changes
Feb 29, 2024
nielsenko
force-pushed
the
kn/fix-argument-order-not-stable
branch
from
24feeed
to
775495d
Compare
nielsenko
added a commit
that referenced
this pull request
Feb 29, 2024
* Use a guarenteed stable sort, when moving calculated properties to the end * Update CHANGELOG
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug reported on slack for realm models with many properties, where the order of ctor arguments would appear random.
Turns out
List.sortis not guaranteed to be stable (but apparently is for small lists).