Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realm list.query #239

Merged
merged 4 commits into from
Feb 8, 2022
Merged

Realm list.query #239

merged 4 commits into from
Feb 8, 2022

Conversation

nielsenko
Copy link
Contributor

Add query method to RealmList class

@cla-bot cla-bot bot added the cla: yes label Feb 4, 2022
test/realm_test.dart Show resolved Hide resolved
@nielsenko nielsenko changed the base branch from RealmList.changed to master February 8, 2022 09:43
@nielsenko nielsenko force-pushed the RealmList.query branch 2 times, most recently from 2eb2da1 to 3568051 Compare February 8, 2022 09:48
@nielsenko
Copy link
Contributor Author

I'll convert to draft for now. This really depends on #162. The type restriction on RealmResult has been lifted in this PR, but we need to ensure we actually support it.

@nielsenko nielsenko marked this pull request as draft February 8, 2022 10:50
@nielsenko nielsenko marked this pull request as ready for review February 8, 2022 14:19
@nielsenko
Copy link
Contributor Author

I'll convert to draft for now. This really depends on #162. The type restriction on RealmResult has been lifted in this PR, but we need to ensure we actually support it.

Actually core does not support filters on primitives. PR has been refactored to align.

Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with some suggestions

lib/src/list.dart Outdated Show resolved Hide resolved
lib/src/list.dart Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Show resolved Hide resolved
Co-authored-by: blagoev <lubo@blagoev.com>
@nielsenko nielsenko linked an issue Feb 8, 2022 that may be closed by this pull request
@nielsenko nielsenko merged commit a1d5ba5 into master Feb 8, 2022
@nielsenko nielsenko deleted the RealmList.query branch February 8, 2022 15:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support query on List
2 participants