support realm equals #304
Merged
support realm equals #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desistefanova
requested review from
blagoev and
nielsenko
and removed request for
blagoev
nielsenko
reviewed
Mar 22, 2022
nielsenko
approved these changes
Mar 22, 2022
Pull Request Test Coverage Report for Build 2040653772
💛 - Coveralls |
…to realm_equals
blagoev
suggested changes
Mar 24, 2022
lib/src/realm_class.dart
Outdated
| @@ -52,19 +52,24 @@ class Realm { | |||
|
|
|||
| /// Opens a `Realm` using a [Configuration] object. | |||
| Realm(Configuration config) : _config = config { | |||
| _scheduler = Scheduler(config, close); | |||
| if (_config.isInUse) { | |||
| throw RealmException("A Realm instance for this configuraiton object already exists."); | |||
There was a problem hiding this comment.
I think this should be RealmStateError. since this is not something people should catching and handling.
test/realm_test.dart
Outdated
| realm1.add(Person('Kasper')); | ||
| }); | ||
|
|
||
| final realm3 = realm1.all<Person>().first.realm; |
There was a problem hiding this comment.
This test does too much. This is testing RealmResults. I suggest we remove this.
blagoev
reviewed
Mar 25, 2022
blagoev
approved these changes
Mar 25, 2022
bmunkholm
reviewed
Mar 28, 2022
| @@ -52,12 +52,15 @@ class Realm { | |||
|
|
|||
| /// Opens a `Realm` using a [Configuration] object. | |||
| Realm(Configuration config) : _config = config { | |||
| _scheduler = Scheduler(config, close); | |||
| if (_config.isInUse) { | |||
| throw RealmStateError("A Realm instance for this configuraiton object already exists."); | |||
There was a problem hiding this comment.
configuraiton -> configuration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Realm
operator ==and Configurationoperator ==. Fixes #161