Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jobs to deploy and cleanup baas on cloud-dev #309

Merged
merged 27 commits into from
Mar 28, 2022
Merged

Add jobs to deploy and cleanup baas on cloud-dev #309

merged 27 commits into from
Mar 28, 2022

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Mar 23, 2022 •
edited
Loading

This is work in progress. Initially will be added only on Linux job and once that works fine, I'll add to remaining jobs.

TODO:

  • Revert unrelated workflow changes
  • Changelog entry

@cla-bot cla-bot bot added the cla: yes label Mar 23, 2022
@nirinchev nirinchev marked this pull request as ready for review March 24, 2022 16:59
@nirinchev
Copy link
Member Author

@nielsenko @blagoev this should be ready-ish for review. I was hoping to get a CI run to confirm, but feel free to start going over it as I don't expect it'll fundamentally change.

@nirinchev nirinchev self-assigned this Mar 24, 2022
nielsenko
nielsenko reviewed Mar 24, 2022
View reviewed changes
test/test.dart Outdated Show resolved Hide resolved
nielsenko
nielsenko reviewed Mar 24, 2022
View reviewed changes
test/test.dart Outdated Show resolved Hide resolved
nirinchev and others added 2 commits March 24, 2022 19:42
@nirinchev @nielsenko
Apply suggestions from code review
b452e1f 
Co-authored-by: Kasper Overgård Nielsen <kasper.nielsen@mongodb.com>
@nielsenko
Nitpicking suggestions
b083f33
@coveralls
Copy link

coveralls commented Mar 24, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2051362341

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.841%
Totals Coverage Status
Change from base Build 2051203846: 0.0%
Covered Lines: 394
Relevant Lines: 429
💛 - Coveralls

nielsenko
nielsenko reviewed Mar 25, 2022
View reviewed changes
.github/workflows/pr.yml Outdated Show resolved Hide resolved
@nirinchev @nielsenko
Update .github/workflows/pr.yml
2c43087 
Co-authored-by: Kasper Overgård Nielsen <kasper.nielsen@mongodb.com>
@nirinchev nirinchev mentioned this pull request Mar 25, 2022
Merged
blagoev
blagoev suggested changes Mar 25, 2022
View reviewed changes
.github/workflows/pr.yml Show resolved Hide resolved
.github/workflows/pr.yml Show resolved Hide resolved
bin/README.md Show resolved Hide resolved
lib/src/cli/deployapps/baas_client.dart Show resolved Hide resolved
lib/src/cli/deployapps/baas_client.dart Outdated Show resolved Hide resolved
test/test.dart Outdated Show resolved Hide resolved
@nirinchev nirinchev merged commit fc665ac into master Mar 28, 2022
@nirinchev nirinchev deleted the ni/baas branch March 28, 2022 11:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fealebenpae fealebenpae fealebenpae left review comments

@blagoev blagoev blagoev approved these changes

@nielsenko nielsenko nielsenko approved these changes

@desistefanova desistefanova desistefanova approved these changes

Assignees

@nirinchev nirinchev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nirinchev @coveralls @fealebenpae @blagoev @nielsenko @desistefanova