-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for data initialization function #441
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
commented
Mar 29, 2022
Pull Request Test Coverage Report for Build 2115316376
💛 - Coveralls |
nielsenko
reviewed
Mar 30, 2022
nielsenko
reviewed
Mar 30, 2022
nielsenko
reviewed
Mar 30, 2022
nielsenko
reviewed
Mar 30, 2022
nielsenko
reviewed
Mar 30, 2022
nielsenko
reviewed
Mar 30, 2022
nielsenko
reviewed
Mar 30, 2022
nielsenko
reviewed
Mar 30, 2022
blagoev
suggested changes
Apr 7, 2022
blagoev
suggested changes
Apr 7, 2022
blagoev
suggested changes
Apr 7, 2022
1d93c03
to
8c6e24c
Compare
8c6e24c
to
a8502e1
Compare
a8502e1
to
48f0191
Compare
48f0191
to
dc80edd
Compare
blagoev
reviewed
Apr 11, 2022
my PR review comments are all over the place. Sorry about that. Don't know how it happens |
972ea0a
to
b8e5c23
Compare
b8e5c23
to
8eaa986
Compare
@blagoev @nielsenko @desistefanova this is now rebased on master and cleaned up, so should be ready for another look. It changed significantly since I integrated the GCHandle approach, so it's likely worth it reviewing the core functionality from scratch. |
Co-authored-by: Desislava Stefanova <95419820+desistefanova@users.noreply.github.com>
desistefanova
suggested changes
Apr 11, 2022
desistefanova
approved these changes
Apr 11, 2022
blagoev
approved these changes
Apr 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #455 and #456, so will rebase on master once those go in.
This adds a
Configuration
property that allows developers to specify a function that imports an initial set of data the first time the Realm is opened.Fixes #298