Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

application credentials anonymous #443

Merged
merged 20 commits into from
Apr 1, 2022
Merged

application credentials anonymous #443

merged 20 commits into from
Apr 1, 2022

Conversation

desistefanova
Copy link
Contributor

Implemented anonymous application credentials. Fixes #391

@cla-bot cla-bot bot added the cla: yes label Mar 29, 2022
@coveralls
Copy link

coveralls commented Mar 29, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2077482702

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.841%
Totals Coverage Status
Change from base Build 2076348759: 0.0%
Covered Lines: 394
Relevant Lines: 429
💛 - Coveralls

nielsenko
nielsenko requested changes Mar 30, 2022
View reviewed changes
lib/src/application_credentials.dart Outdated Show resolved Hide resolved
blagoev
blagoev suggested changes Mar 30, 2022
View reviewed changes
lib/src/app_credentials.dart Outdated Show resolved Hide resolved
lib/src/app_credentials.dart Outdated Show resolved Hide resolved
lib/src/app_credentials.dart Outdated Show resolved Hide resolved
lib/src/app_credentials.dart Outdated Show resolved Hide resolved
lib/src/app_credentials.dart Outdated Show resolved Hide resolved
lib/src/app_credentials.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
blagoev
blagoev reviewed Mar 30, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
desistefanova and others added 5 commits March 30, 2022 23:53
@desistefanova @blagoev
Update CHANGELOG.md
5c21561 
Co-authored-by: blagoev <lubo@blagoev.com>
@desistefanova @blagoev
Update lib/src/app_credentials.dart
507885a 
Co-authored-by: blagoev <lubo@blagoev.com>
@desistefanova @blagoev
Update lib/src/app_credentials.dart
ffa3eaf 
Co-authored-by: blagoev <lubo@blagoev.com>
@desistefanova
code review changes
8e9418b
@desistefanova
RealmAppCredentialsHandle pointer size set
7784c23
blagoev
blagoev reviewed Mar 31, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
blagoev
blagoev suggested changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate in changelog.md

nirinchev
nirinchev reviewed Apr 1, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
lib/src/app_credentials.dart Outdated Show resolved Hide resolved
@desistefanova desistefanova merged commit 0ba6c8e into master Apr 1, 2022
@desistefanova desistefanova deleted the app_credentials_anonymous branch April 1, 2022 14:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nirinchev nirinchev nirinchev left review comments

@blagoev blagoev blagoev approved these changes

@nielsenko nielsenko Awaiting requested review from nielsenko

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support App Credentials anonymous
5 participants
@desistefanova @coveralls @nirinchev @blagoev @nielsenko