Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a helper to create a realm instance #454

Merged
merged 3 commits into from
Apr 8, 2022
Merged

Use a helper to create a realm instance #454

merged 3 commits into from
Apr 8, 2022

Conversation

nirinchev
Copy link
Member

This takes care of automatically closing and deleting it

@cla-bot cla-bot bot added the cla: yes label Mar 31, 2022
@nirinchev nirinchev requested a review from blagoev March 31, 2022 16:16
@nirinchev nirinchev self-assigned this Mar 31, 2022
@coveralls
Copy link

coveralls commented Mar 31, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2112113106

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.841%
Totals Coverage Status
Change from base Build 2109494262: 0.0%
Covered Lines: 394
Relevant Lines: 429
💛 - Coveralls

@nirinchev nirinchev merged commit e4a9fd4 into master Apr 8, 2022
@nirinchev nirinchev deleted the ni/get-realm-helper branch April 8, 2022 09:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@desistefanova desistefanova desistefanova left review comments

@blagoev blagoev blagoev approved these changes

Assignees

@nirinchev nirinchev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nirinchev @coveralls @blagoev @desistefanova