Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support uuids #470

Merged
merged 3 commits into from
Apr 17, 2022
Merged

support uuids #470

merged 3 commits into from
Apr 17, 2022

Conversation

blagoev
Copy link
Contributor

@blagoev blagoev commented Apr 12, 2022

this supersedes #462 fixes #463

@cla-bot cla-bot bot added the cla: yes label Apr 12, 2022
@coveralls
Copy link

coveralls commented Apr 12, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2159750325

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.784%
Totals Coverage Status
Change from base Build 2159195303: 0.0%
Covered Lines: 391
Relevant Lines: 426
💛 - Coveralls

@blagoev blagoev mentioned this pull request Apr 12, 2022
Closed
desistefanova
desistefanova approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@desistefanova desistefanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good to be described in CHANGELOG.md maybe together with ObjectId.

  • Support ObjectId and Uuid types in RealmModel.

@blagoev
Copy link
Contributor Author

blagoev commented Apr 13, 2022

@desistefanova I forgot the CHANGELOG will add an entry

@blagoev blagoev merged commit a2373df into master Apr 17, 2022
@blagoev blagoev deleted the support-uuid branch April 17, 2022 20:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@desistefanova desistefanova desistefanova approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for UUID properties
3 participants
@blagoev @coveralls @desistefanova