tests: email/password confirm user #506
Conversation
Pull Request Test Coverage Report for Build 2276902009
💛 - Coveralls |
| "0e6340a446e68fe02a1af1b53c34d5f630b601ebf807d73d10a7fed5c2e996d87d04a683030377ac6058824d8555b24c1417de79019b40f1299aada7ef37fddc", | ||
| "6268f7dd73fafea76b730fc9"); |
There was a problem hiding this comment.
How are these tokens generated?
There was a problem hiding this comment.
They were sent to my email after registration. I just copied them. They are old tokens, but in a valid format. In this case the validation is throwing different exception.
There was a problem hiding this comment.
Hm... I may be wrong, but I don't think we'll be able to use them like that. These are just strings and not JWTs that encode their expiration - I believe they're just stored in the database, so when you try to run this test against a different app, it'll fail with invalid token rather than expired token. Once we fix test runs on CI, I expect this test to fail, but let's see.
There was a problem hiding this comment.
Yes, right, but they are running on the same app in this manual test. It would be good if I had the server code to check the validation, but I couldn't access it.
There was a problem hiding this comment.
if this is a manual test shouldn't it be skipped by default
There was a problem hiding this comment.
This test is not manual. We are passing expired tokens and the exception is thrown.
Co-authored-by: Nikola Irinchev <irinchev@me.com>
| "0e6340a446e68fe02a1af1b53c34d5f630b601ebf807d73d10a7fed5c2e996d87d04a683030377ac6058824d8555b24c1417de79019b40f1299aada7ef37fddc", | ||
| "6268f7dd73fafea76b730fc9"); |
There was a problem hiding this comment.
if this is a manual test shouldn't it be skipped by default
test/credentials_test.dart
Outdated
| }, appName: "emailConfirm"); | ||
|
|
||
| group("Email/Password - confirm user - manual tests", () { | ||
| // The tests in this group are for manual testing, since they require interaction with mail box. |
There was a problem hiding this comment.
could we move the comment to be on the group call. Also could we rename all manual tests to include Manual in the name
Create tests for email/password confirm user tokens and auto confirm user.