tests: email/password resend user confirmation email #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nikola Irinchev <irinchev@me.com>
desistefanova
requested review from
blagoev,
nirinchev and
nielsenko
and removed request for
blagoev and
nirinchev
Pull Request Test Coverage Report for Build 2277136314
💛 - Coveralls |
blagoev
suggested changes
May 4, 2022
Co-authored-by: blagoev <lubo@blagoev.com>
Co-authored-by: blagoev <lubo@blagoev.com>
…thub.com/realm/realm-dart into retry_custom_confirmation_function_tests
Co-authored-by: blagoev <lubo@blagoev.com>
Co-authored-by: blagoev <lubo@blagoev.com>
…send_confirm_tests
desistefanova
changed the base branch from
master
to
retry_custom_confirmation_function_tests
desistefanova
changed the base branch from
retry_custom_confirmation_function_tests
to
master
desistefanova
changed the base branch from
master
to
retry_custom_confirmation_function_tests
nielsenko
approved these changes
May 5, 2022
nirinchev
reviewed
May 5, 2022
test/credentials_test.dart
Outdated
| @@ -22,13 +22,13 @@ import 'package:test/test.dart' hide test, throws; | |||
| import '../lib/realm.dart'; | |||
| import 'test.dart'; | |||
|
|
|||
| Future<User> retryLogin(int retries, Future<User> Function(Credentials credentials) doFunction, Credentials credentials) async { | |||
| Future<User> loginWithRetry(App app, Credentials credentials, int retryCount) async { | |||
There was a problem hiding this comment.
It's a good idea to make the retryCount optional here or even hardcode it to some value. The only reason to have a retryCount is to make sure we don't retry forever, but there's no reason for consumers of the method to control the value.
blagoev
approved these changes
May 5, 2022
Base automatically changed from
retry_custom_confirmation_function_tests
to
master
May 5, 2022 16:57
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create tests for email/password - confirm user after resend user confirmation email.