Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app and user tests #556

Merged
merged 10 commits into from May 10, 2022
Merged

Add app and user tests #556

merged 10 commits into from May 10, 2022

Conversation

blagoev
Copy link
Contributor

@blagoev blagoev commented May 8, 2022

Added a bunch of tests for app and user functionality

closes #554
closes #555
closes #548
closes #549
closes #552
closes #551
closes #553
closes #550

Issue #547 is implemented but is blocked on realm/realm-core#5467

This PR also creates a well known test email\password user in every app.

…h user, get users

added User tests for logout, get id, get identities, get custom data, refresh custom data, link credentials
fixed README.md test setup instructions
exposed UserState in realm_class
fixed UserState enum order to match Core order
added user.equals operator.
fixed customData to return null correctly instead of failing. The null value here is not a flag for failure.
fixed logOut user to properly logout current user when no user is specified
refactored app.logout to not require an argument to logout the current user
added user tests
added a well known test user to all apps
@cla-bot cla-bot bot added the cla: yes label May 8, 2022
@coveralls
Copy link

coveralls commented May 8, 2022

Pull Request Test Coverage Report for Build 2298225004

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.677%

Totals Coverage Status
Change from base Build 2296239506: 0.0%
Covered Lines: 400
Relevant Lines: 427

💛 - Coveralls

@blagoev blagoev self-assigned this May 8, 2022
lib/src/user.dart Outdated Show resolved Hide resolved
test/app_test.dart Outdated Show resolved Hide resolved
test/app_test.dart Outdated Show resolved Hide resolved
@blagoev blagoev requested a review from desistefanova May 9, 2022 10:36
Copy link
Contributor

@desistefanova desistefanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter Tests Android failed, maybe have to be re-run only.

@desistefanova desistefanova self-requested a review May 9, 2022 11:10
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I mostly have minor comments

lib/src/cli/deployapps/baas_client.dart Outdated Show resolved Hide resolved
lib/src/app.dart Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
test/app_test.dart Outdated Show resolved Hide resolved
test/app_test.dart Outdated Show resolved Hide resolved
test/app_test.dart Show resolved Hide resolved
test/user_test.dart Outdated Show resolved Hide resolved
test/user_test.dart Show resolved Hide resolved
test/user_test.dart Outdated Show resolved Hide resolved
@blagoev blagoev merged commit 0c81709 into master May 10, 2022
@blagoev blagoev deleted the add-app-and-user-tests branch May 10, 2022 03:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants