New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add app and user tests #556
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h user, get users added User tests for logout, get id, get identities, get custom data, refresh custom data, link credentials fixed README.md test setup instructions exposed UserState in realm_class fixed UserState enum order to match Core order added user.equals operator. fixed customData to return null correctly instead of failing. The null value here is not a flag for failure. fixed logOut user to properly logout current user when no user is specified refactored app.logout to not require an argument to logout the current user added user tests added a well known test user to all apps
Pull Request Test Coverage Report for Build 2298225004
💛 - Coveralls |
blagoev
force-pushed
the
add-app-and-user-tests
branch
from
May 9, 2022 10:32
caaaa1e
to
2400b30
Compare
desistefanova
approved these changes
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flutter Tests Android failed, maybe have to be re-run only.
nirinchev
reviewed
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I mostly have minor comments
nirinchev
reviewed
May 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a bunch of tests for app and user functionality
closes #554
closes #555
closes #548
closes #549
closes #552
closes #551
closes #553
closes #550
Issue #547 is implemented but is blocked on realm/realm-core#5467
This PR also creates a well known test email\password user in every app.