Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Jobs re-run per environment #663

Merged
merged 138 commits into from
Jul 4, 2022
Merged

CI Jobs re-run per environment #663

merged 138 commits into from
Jul 4, 2022

Conversation

desistefanova
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla: yes label Jun 9, 2022
@desistefanova desistefanova marked this pull request as draft June 9, 2022 09:20
@desistefanova desistefanova self-assigned this Jun 9, 2022
@nirinchev nirinchev mentioned this pull request Jun 17, 2022
Merged
nirinchev
nirinchev requested changes Jun 17, 2022
View reviewed changes
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested #673 as an improvement to move the deploy/cleanup steps to separate jobs and speed up the workflow execution.

.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
lib/src/cli/atlas_apps/baas_client.dart Show resolved Hide resolved
lib/src/cli/atlas_apps/deleteapps_command.dart Outdated Show resolved Hide resolved
lib/src/cli/atlas_apps/deployapps_command.dart Outdated Show resolved Hide resolved
nirinchev
nirinchev approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a little concerned about the connection situation, but we can tackle that later.

.github/workflows/ci.yml Show resolved Hide resolved
@blagoev @nirinchev
Update .github/workflows/ci.yml
06ce55f 
Co-authored-by: Nikola Irinchev <irinchev@me.com>
@desistefanova desistefanova merged commit 2b992be into master Jul 4, 2022
@desistefanova desistefanova deleted the ds/ci_rerun_per_env branch July 4, 2022 06:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nirinchev nirinchev nirinchev approved these changes

@blagoev blagoev blagoev approved these changes

@nielsenko nielsenko Awaiting requested review from nielsenko

Assignees

@desistefanova desistefanova

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@desistefanova @blagoev @nirinchev @nielsenko