Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open realm async #731

Merged
merged 138 commits into from
Oct 18, 2022
Merged

Open realm async #731

merged 138 commits into from
Oct 18, 2022

Conversation

desistefanova
Copy link
Contributor

@desistefanova desistefanova commented Jul 30, 2022 •
edited
Loading

Support async Realm open syntax. Fixes #71
Done:

  • Implement Realm.open only in Dart without using C-API.
  • CancellableFuture implementation.
  • Update Changelog.md
  • API documentation
  • Add more tests for download progress.
  • Test opening many realms with different configs and try to cancel one of them.

@cla-bot cla-bot bot added the cla: yes label Jul 30, 2022
@desistefanova desistefanova self-assigned this Jul 30, 2022
desistefanova
desistefanova commented Jul 30, 2022
View reviewed changes
test/realm_test.dart Outdated Show resolved Hide resolved
@desistefanova desistefanova marked this pull request as ready for review August 15, 2022 16:10
@desistefanova desistefanova requested review from blagoev, nielsenko and nirinchev and removed request for nielsenko August 15, 2022 16:10
@desistefanova desistefanova marked this pull request as draft October 13, 2022 13:26
@desistefanova desistefanova marked this pull request as ready for review October 13, 2022 18:30
nielsenko
nielsenko approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of replacing Future.wait here, but I reluctantly accept 🥲

I have added a few suggestions..

lib/src/realm_class.dart Outdated Show resolved Hide resolved
lib/src/realm_class.dart Outdated Show resolved Hide resolved
blagoev
blagoev suggested changes Oct 18, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
lib/src/realm_class.dart Outdated Show resolved Hide resolved
lib/src/realm_class.dart Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
test/realm_test.dart Outdated Show resolved Hide resolved
test/realm_test.dart Outdated Show resolved Hide resolved
test/realm_test.dart Outdated Show resolved Hide resolved
test/realm_test.dart Outdated Show resolved Hide resolved
test/test.dart Outdated Show resolved Hide resolved
@desistefanova desistefanova merged commit 6852094 into master Oct 18, 2022
@desistefanova desistefanova deleted the ds/open_realm_async branch October 18, 2022 13:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nielsenko nielsenko nielsenko approved these changes

@nirinchev nirinchev Awaiting requested review from nirinchev

@blagoev blagoev Awaiting requested review from blagoev

Assignees

@desistefanova desistefanova

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open: Support async Realm open
5 participants
@desistefanova @nielsenko @coveralls @nirinchev @blagoev